Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update cronjob_controller.go: simplify setting mostRecentTime logic #3700

Merged
merged 1 commit into from
Dec 7, 2023
Merged

📖 Update cronjob_controller.go: simplify setting mostRecentTime logic #3700

merged 1 commit into from
Dec 7, 2023

Conversation

hp685
Copy link
Contributor

@hp685 hp685 commented Dec 4, 2023

simplify setting mostRecentTime logic
The change consolidates conditions under which mostRecentTime can be set to scheduledTimeForJob for better readability

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @hp685!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @hp685. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86
camilamacedo86 reviewed Dec 5, 2023
View reviewed changes
docs/book/src/cronjob-tutorial/testdata/project/internal/controller/cronjob_controller.go Outdated
if mostRecentTime == nil {
mostRecentTime = scheduledTimeForJob
} else if mostRecentTime.Before(*scheduledTimeForJob) {
if mostRecentTime == nil || mostRecentTime.Before(*scheduldTimeForJob) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great
But the change must be done in:

kubebuilder/hack/docs/internal/cronjob-tutorial/controller_implementation.go

Line 208 in c172069

mostRecentTime = scheduledTimeForJob

Then, you will run make generate which will call the docs generate and it will get updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the emoji in this case is :book:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @camilamacedo86! Updated.

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2023
@hp685 hp685 changed the title 🌱 Update cronjob_controller.go: simplify setting mostRecentTime logic 📖 Update cronjob_controller.go: simplify setting mostRecentTime logic Dec 5, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2023
@camilamacedo86
Copy link
Member

camilamacedo86 commented Dec 6, 2023 •
edited
Loading

Hi @hp685

It is missing just a nit to allow we get your contribution 🥇 merged
Can you please squash the commits?

We should have only one commit per PR.

also, please ensure that your PR is rebased with master branch
And you can ignore the check APIDiff / Verify API differences in this case.

@hp685
simplify setting mostRecentTime logic
24a486a 
The change consolidates conditions under which mostRecentTime can be set to scheduledTimeForJob for better readability
@hp685
Copy link
Contributor Author

hp685 commented Dec 7, 2023

Hi @hp685

It is missing just a nit to allow we get your contribution 🥇 merged Can you please squash the commits?

We should have only one commit per PR.

also, please ensure that your PR is rebased with master branch And you can ignore the check APIDiff / Verify API differences in this case.

Done :)

camilamacedo86
camilamacedo86 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

?lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, hp685

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@camilamacedo86 camilamacedo86 merged commit 79cec87 into kubernetes-sigs:master Dec 7, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hp685 @k8s-ci-robot @camilamacedo86