-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (go/v4): fix make help instruction in the README #3719
🐛 (go/v4): fix make help instruction in the README #3719
Conversation
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 🥇
But you also need to run make generate
so that we can update the samples under the testdata and used in the docs with this change.
Could you please run it and then ensure that you squash the commits for we get it merged?
/ok-to-test
@@ -39,7 +39,7 @@ func (f *Dockerfile) SetTemplateDefaults() error { | |||
} | |||
|
|||
const dockerfileTemplate = `# Build the manager binary | |||
FROM golang:1.20 as builder | |||
FROM golang:1.20 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a PR for each fix as well?
Could you please open another PR for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will update this one and create the other one in a few
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
84d0dd3
to
81c99b2
Compare
For we are able to merge this you need to rebase it with the master branch and push. Can you please do that? |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
81c99b2
to
24bfd1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update README template for golang/v4 plugin (v2 and v3 are deprecated and will be removed soon).
Motivation
Use right command.
Related issues
No related issues