-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Start to build CLI binary for linux_s390x as target #3741
✨ Start to build CLI binary for linux_s390x as target #3741
Conversation
Welcome @ShivangGoswami! |
Hi @ShivangGoswami. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR might generate the CLI bin for this arch. I will try to give it a look at it prior to the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are building the auth-proxy image and, in the past, it was decided in the Community Meetings that we could start to make the binaries for it, why not move forward with this one?
However, we still need to build the ENV TEST binaries to allow the tool to work correctly in this environment.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, ShivangGoswami The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Issue: #3740
this PR adds support for s390x through go release so that the required binaries are generated when these assets are generated via GitHub-actions