Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ remove kustomize/v1, go/v2 and go/v3, and configurations for Project Config v2 related to legacy Kubebuilder CLI version < 3 #3763

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jan 30, 2024

Description
Remove deprecated plugins and doc sections as specific related tests.

  • Remove golang v2 and v3
  • Remove kustomize/v1

Motivation
Maintainability and better usability
More info: #3622
(began to prepare the master branch for a V4 release)

@camilamacedo86
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2024
@camilamacedo86 camilamacedo86 changed the title ⚠️ remove kustomize/v1, go/v2 and go/v3configurations as Project Config v2 from legacy Kubebuilder CLI version < 3 (WIP) ⚠️ remove kustomize/v1, go/v2 and go/v3configurations as Project Config v2 from legacy Kubebuilder CLI version < 3 Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@camilamacedo86 camilamacedo86 changed the title (WIP) ⚠️ remove kustomize/v1, go/v2 and go/v3configurations as Project Config v2 from legacy Kubebuilder CLI version < 3 (WIP) ⚠️ remove kustomize/v1, go/v2 and go/v3, and configurations for Project Config v2 related to legacy Kubebuilder CLI version < 3 Jan 30, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 30, 2024
@camilamacedo86 camilamacedo86 changed the title (WIP) ⚠️ remove kustomize/v1, go/v2 and go/v3, and configurations for Project Config v2 related to legacy Kubebuilder CLI version < 3 ⚠️ remove kustomize/v1, go/v2 and go/v3, and configurations for Project Config v2 related to legacy Kubebuilder CLI version < 3 Jan 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@camilamacedo86
Copy link
Member Author

Hi @varshaprasad96 and @everettraven

I will wait until next week for us start to removing all stuff
So that we have an easy chance to release, like 3.14.1, and address any bugs or minor issues before.

Because changes in the API, it must be merged manually, so if you are able to look at and approve this one that would be great and we will only move forward anyway manually from next week

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a first quick pass it looks good. I'll take a deeper look again.

cmd/main.go Outdated Show resolved Hide resolved
pkg/config/store/yaml/store_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2024
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Mar 30, 2024

HI @varshaprasad96

Thank you a lot.
It is updated now.

Let's to do a patch release for what was fixed so far and then we can start to get this one merged and start to work in our MAJOR version bump Kubebuilder v4 as we have speaking so far where we have all cleaned up.

:-)

/hold

@camilamacedo86 camilamacedo86 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2024

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-29-0 0ef3140 link true /test pull-kubebuilder-e2e-k8s-1-29-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@camilamacedo86 camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@camilamacedo86
Copy link
Member Author

I am moving within since
@varshaprasad96 already gave a first review
and we are just removing what is deprecated (agreed and communicated a long time ago)

We need to merge this one in order to be able to add support for k8s 1.30 and go 1.22

@camilamacedo86 camilamacedo86 merged commit 5a7e207 into kubernetes-sigs:master May 16, 2024
16 of 18 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-deprecated-plugins branch May 16, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants