Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (go/v4,kustomize/v2): fix roles names for projects with multi-group layout #3845

Merged
merged 1 commit into from
Apr 5, 2024
Merged

🐛 (go/v4,kustomize/v2): fix roles names for projects with multi-group layout #3845

merged 1 commit into from
Apr 5, 2024

Conversation

camilamacedo86
Copy link
Member

This PR will unblock: #3800

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: camilamacedo86 / name: Camila Macedo (96274c6)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@camilamacedo86 camilamacedo86 mentioned this pull request Apr 5, 2024
Merged
@camilamacedo86
Copy link
Member Author

/easyCLA

@camilamacedo86 camilamacedo86 changed the title 🐛 fix roles names for projects with multi-group layout 🐛 (go/v4,kustomize/v2): fix roles names for projects with multi-group layout Apr 5, 2024
@camilamacedo86 camilamacedo86 reopened this Apr 5, 2024
@jarias-lfx
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 5, 2024
lunarwhite
lunarwhite reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really appreciate your quick fix!

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6bcd440 into kubernetes-sigs:master Apr 5, 2024
31 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-role-name branch April 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunarwhite lunarwhite lunarwhite left review comments

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @k8s-ci-robot @jarias-lfx @lunarwhite