-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade images used in the samples and e2e tests for deployImage plugin #3849
🌱 Upgrade images used in the samples and e2e tests for deployImage plugin #3849
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kubebuilder-e2e-k8s-1-29-2 Reason:https://kubernetes.slack.com/archives/CCK68P2Q2/p1712378775102839 |
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-29-2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just bumping the images to keep in edge.
it has no reason to make someone spending time in the review.
Passing in the e2e test is enough to allow we move forward.
So, moving forward with this one
/override pull-kubebuilder-e2e-k8s-1-29-2 Reason:https://kubernetes.slack.com/archives/CCK68P2Q2/p1712378775102839 |
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-29-2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upgrade images used in the samples and e2e tests for deployImage plugin