Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ remove component config #3916

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 16, 2024

ComponentConfig is no longer provided by controller-runtime.
See: #3469

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-component-config-tutorial branch from cadca5f to c8f1dae Compare May 16, 2024 18:44
@camilamacedo86 camilamacedo86 force-pushed the remove-component-config-tutorial branch from c8f1dae to bd83ee6 Compare May 16, 2024 18:47
@camilamacedo86 camilamacedo86 changed the title 📖 remove component config tutorial ⚠️ remove component config May 16, 2024
@camilamacedo86 camilamacedo86 merged commit e227a13 into kubernetes-sigs:master May 16, 2024
19 of 21 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-component-config-tutorial branch May 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants