🐛 fix place where metrics service is scaffolded by moving from config/rbac to config/default #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
requested review from
joelanford
and removed request for
Kavinjsir and
everettraven
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
2136c58
to
a6a4bf9
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
a6a4bf9
to
f966d02
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
2 times, most recently
from
fa283ef
to
7ef4c2c
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
7ef4c2c
to
aeaa8b6
Compare
k8s-ci-robot
added
size/S
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
aeaa8b6
to
44d93e7
Compare
k8s-ci-robot
added
size/XXL
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
44d93e7
to
7b5f3a0
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
5 times, most recently
from
4ab0071
to
22a8425
Compare
…bac to config/default When we discontinued the usage of kube-rbac-proxy we placed the Metrics Service under config/rbac but it is not the best place to fit this resource. Furthermore, within those changes we are ensuring that the metrics service will only be applied if/when users enable the metrics.
camilamacedo86
force-pushed
the
fix-place-metrics-service
branch
from
22a8425
to
b817e1f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
camilamacedo86
merged commit e1497bf
into
kubernetes-sigs:master
16 of 18 checks passed
camilamacedo86
added a commit
that referenced
this pull request
May 23, 2024
…y moving from config/rbac to config/default (#3948) (cherry-pick #3945) fix place where metrics service is scaffolded by moving from config/rbac to config/default (#3948) When we discontinued the usage of kube-rbac-proxy we placed the Metrics Service under config/rbac but it is not the best place to fit this resource. Furthermore, within those changes we are ensuring that the metrics service will only be applied if/when users enable the metrics. * Upgrade sample testdata in the v3x branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we discontinued the usage of kube-rbac-proxy we placed the Metrics Service under
config/rbacbut it is not the best place to fit this resource. Furthermore, within those changes we are ensuring that the metrics service will only be applied if/when users enable the metrics.