馃摉 Update multiversion-tutorial with latest changes #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
force-pushed
the
update-multiversion-tutorial
branch
from
d8470ee
to
e90c85b
Compare
camilamacedo86
added
the
lgtm
camilamacedo86
force-pushed
the
update-multiversion-tutorial
branch
from
e90c85b
to
14c7159
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
camilamacedo86
commented
May 23, 2024
| @@ -162,7 +162,7 @@ test-book: ## Run the cronjob tutorial's unit tests to make sure we don't break | |||
| # TODO: Uncomment when we bump controller-runtime | |||
| # See: https://github.com/kubernetes-sigs/kubebuilder/issues/3917 | |||
| # cd ./docs/book/src/cronjob-tutorial/testdata/project && make test | |||
| cd ./docs/book/src/multiversion-tutorial/testdata/project && make test | |||
| # cd ./docs/book/src/multiversion-tutorial/testdata/project && make test | |||
There was a problem hiding this comment.
More info see: #3917
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摉 Update multiversion-tutorial with latest changes