Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 cleanup e2e tests for go/v4 #3958

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 25, 2024

Encapsulate logic to allow us grow the checks and tests
Remove duplications

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2024
@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 25, 2024
@camilamacedo86 camilamacedo86 changed the title 馃尡 cleanup: encapsulate metrics code for e2e tests WIP: 馃尡 cleanup: encapsulate metrics code for e2e tests May 25, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2024
@camilamacedo86 camilamacedo86 force-pushed the tests-e2e-cleanup branch 6 times, most recently from 35a99c5 to 65e4dd7 Compare May 27, 2024 19:51
@camilamacedo86 camilamacedo86 changed the title WIP: 馃尡 cleanup: encapsulate metrics code for e2e tests 馃尡 cleanup e2e tests for go/v4 May 27, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@camilamacedo86 camilamacedo86 force-pushed the tests-e2e-cleanup branch 2 times, most recently from fa46c54 to 8b8db8a Compare May 27, 2024 20:14
@camilamacedo86 camilamacedo86 merged commit f52fce0 into kubernetes-sigs:master May 27, 2024
15 of 17 checks passed
@camilamacedo86 camilamacedo86 deleted the tests-e2e-cleanup branch May 27, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants