Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix validation used to ensure Kind versions pattern #3986

Merged
merged 1 commit into from
Jul 21, 2024
Merged

🐛 fix validation used to ensure Kind versions pattern #3986

merged 1 commit into from
Jul 21, 2024

Conversation

Kavinjsir
Copy link
Contributor

Description

Refactor the version validation to allow version values follow:

  • Either literal string __internal
  • OR DNS-1123

Motivation

Resolve #3739

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
@Kavinjsir
Copy link
Contributor Author

@camilamacedo86 I'm trying to follow your comment at: #3739 (comment) to create this PR.

However, I feel like I'm a bit confused.
Assuming we are working under the scope of validating the pattern for Version, do we have to align it with a DNS format?

@Kavinjsir Kavinjsir mentioned this pull request Jun 14, 2024
Closed
@camilamacedo86 camilamacedo86 changed the title 🌱: enforce version to follow dns-1123 🐛 fix validation used to ensure Kind versions pattern Jul 21, 2024
@camilamacedo86
Copy link
Member

camilamacedo86 commented Jul 21, 2024 •
edited
Loading

Hi @Kavinjsir

Thank you 🥇
Good work 🚀

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6bb9d29 into kubernetes-sigs:master Jul 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@varshaprasad96 varshaprasad96 varshaprasad96 left review comments

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

versionPattern should be more flexible to allow internal versions
4 participants
@Kavinjsir @k8s-ci-robot @camilamacedo86 @varshaprasad96