-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Upgrade controller-gen used to generated the docs and remove redirects for artefact images #4010
📖 Upgrade controller-gen used to generated the docs and remove redirects for artefact images #4010
Conversation
af5c473
to
5d90915
Compare
5d90915
to
32a92c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! rubber-stamp approval as a user
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, davidxia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice! Thank you! lgtm |
1248eee
to
0638d37
Compare
0638d37
to
207a5c5
Compare
424516e
to
33a6a4c
Compare
…cts for artefact images This PR update the deps used to generate the data in the docs. It should update the markers to address kubernetes-sigs#4009 Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used. We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen. Close: kubernetes-sigs#4009
33a6a4c
to
cfdbc18
Compare
This PR update the deps used to generate the data in the docs.
It should update the markers to address #4009
Furthermore, for we are able to move forward here we need to remove the redirect for
https://go.kubebuilder.io/images
andgcr.io/kubebuilder/thirdparty
which are deprecated and/or no longer used.We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.
Close: #4009