📖 Upgrade controller-gen used to generated the docs and remove redirects for artefact images #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
camilamacedo86
changed the title
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
from
af5c473
to
5d90915
Compare
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
from
5d90915
to
32a92c3
Compare
davidxia
approved these changes
Jul 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, davidxia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice! Thank you! lgtm |
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
from
1248eee
to
0638d37
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
from
0638d37
to
207a5c5
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
3 times, most recently
from
424516e
to
33a6a4c
Compare
…cts for artefact images This PR update the deps used to generate the data in the docs. It should update the markers to address kubernetes-sigs#4009 Furthermore, for we are able to move forward here we need to remove the redirect for `https://go.kubebuilder.io/images` and `gcr.io/kubebuilder/thirdparty` which are deprecated and/or no longer used. We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen. Close: kubernetes-sigs#4009
camilamacedo86
force-pushed
the
update-docs-controller-gen
branch
from
33a6a4c
to
cfdbc18
Compare
camilamacedo86
added
the
lgtm
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the deps used to generate the data in the docs.
It should update the markers to address #4009
Furthermore, for we are able to move forward here we need to remove the redirect for
https://go.kubebuilder.io/imagesandgcr.io/kubebuilder/thirdpartywhich are deprecated and/or no longer used.We are either adding a note in the in the Artefacts page to clarify that ENV TEST binaries are no longer produced by Kubebuilder and its build and promotion was moved to controller-gen.
Close: #4009