📖 Improve and Simplify the Getting Started Guide #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilamacedo86
commented
Aug 23, 2024
•
camilamacedo86
commented
- Refined the sample code implementation to keep it minimal, helping users better understand the core concepts.
- Properly implement automation to generate the sample
- Streamlined the guide by focusing on the main information and removing extraneous details.
- Ensured that the code and samples in the guide are consistent with the generated project.
- Simplified navigation by hiding the full code, making it easier for users to follow along.
- Replaced the use of the deploy image plugin with direct commands to provide more comprehensive and straightforward information.
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
2 times, most recently
from
e3dccda
to
9153231
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
9153231
to
50e16d5
Compare
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
50e16d5
to
747146a
Compare
|
c/c @TAM360 |
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
2 times, most recently
from
093bbdc
to
be4ee4a
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
be4ee4a
to
965c8d1
Compare
k8s-ci-robot
added
size/XXL
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
4 times, most recently
from
4e4177e
to
26ea6f0
Compare
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
2 times, most recently
from
9b82671
to
27bda98
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
27bda98
to
477abdb
Compare
k8s-ci-robot
added
needs-rebase
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
477abdb
to
5457a5a
Compare
k8s-ci-robot
added
needs-rebase
varshaprasad96
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Looks good from my end.
/lgtm
/approve
Adding in /hold, so that the PR doesn't get auto merged and @TAM360 gets a chance for review.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like the PR needs to be rebased. |
varshaprasad96
added
the
do-not-merge/hold
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
5457a5a
to
43690b1
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
needs-rebase
|
@TAM360 I know that you are checking the docs and seen how you can help out. So, I am moving here with this one, we have many open prs and we can push improvements in follow up always ! |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
camilamacedo86
added
the
lgtm
- Refined the sample code implementation to keep it minimal, helping users better understand the core concepts. - Streamlined the guide by focusing on the main information and removing extraneous details. - Ensured that the code and samples in the guide are consistent with the generated project. - Simplified navigation by hiding the full code, making it easier for users to follow along. - Replaced the use of the deploy image plugin with direct commands to provide more comprehensive and straightforward information.
camilamacedo86
force-pushed
the
getting-started-use-sample
branch
from
43690b1
to
25d87e2
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.