🌱 ci: fix e2e tests for samples #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
I am moving forward here because we need to ensure the CI |
camilamacedo86
force-pushed
the
fix-test-e2e-ci
branch
from
0370b28
to
27b2443
Compare
camilamacedo86
added
the
lgtm
The current test is not properly testing the e2e of the samples. Either we have an issue the e2e tests scaffolds for deploy-image sample but we will need to fix it in a follow up PR
camilamacedo86
force-pushed
the
fix-test-e2e-ci
branch
from
27b2443
to
841dcd9
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
camilamacedo86
merged commit fb432c4
into
kubernetes-sigs:master
13 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test is not properly testing the e2e of the samples. Either we have an issue the e2e tests scaffolds for deploy-image sample but we will need to fix it in a follow up PR because more changes in the scaffold will be required.