Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: ensure unique controller names to fix name conflicts in multigroup setup #4162

Merged
merged 1 commit into from
Sep 13, 2024
Merged

🐛 fix: ensure unique controller names to fix name conflicts in multigroup setup #4162

merged 1 commit into from
Sep 13, 2024

Conversation

camilamacedo86
Copy link
Member

Closes: #4161

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 12, 2024
Merged
@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 12, 2024
@camilamacedo86
Copy link
Member Author

It is a small bug fix which blocks we validate the multigroup layout where the bug was found #4154 so that we can prevent things like that. It also blocks other initiatives since we want ensure that all possible scenarios are well tested before decouple the webhooks from apis and simplify/fix the kustomize scaffolds for cert-manager: #4123

So, I will not make nobody waste time on this one. we have more big fishes to fry.
Moving forward since the changes are indeed either validate via e2e tests already.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 29a22d1 into kubernetes-sigs:master Sep 13, 2024
21 checks passed
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 17, 2024
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multigroup Layout Fails with Name Conflicts Across Different Groups/Versions
2 participants
@camilamacedo86 @k8s-ci-robot