✨ (go/v4): e2e tests: add data collection on failures and code simplification #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
camilamacedo86
requested review from
stmcginnis
and removed request for
Kavinjsir and
varshaprasad96
k8s-ci-robot
added
approved
|
c/c @mogsie |
mogsie
reviewed
Sep 16, 2024
| @@ -115,9 +158,8 @@ var _ = Describe("Manager", Ordered, func() { | |||
| ) | |||
| output, err := utils.Run(cmd) | |||
| g.Expect(err).NotTo(HaveOccurred()) | |||
| g.Expect(string(output)).To(BeEquivalentTo("Running"), "Incorrect controller-manager pod status") | |||
| g.Expect(output).To(BeEquivalentTo("Running"), "Incorrect controller-manager pod status") | |||
There was a problem hiding this comment.
Suggested change
| g.Expect(output).To(BeEquivalentTo("Running"), "Incorrect controller-manager pod status") | |
| g.Expect(output).To(Equal("Running"), "Incorrect controller-manager pod status") |
|
This is great @camilamacedo86! I struggled with my kind cluster and some problems were only solved by looking into the container logs and events. This will help a lot. Just a tiny additional change, otherwise it looks good! /approve (not sure I'm allowed to approve, but hey, I'll try!) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mogsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…cation - Gather logs, events, and pod descriptions when tests fail - utils.Cmd returning string instead of []bytes for code simplification
camilamacedo86
force-pushed
the
improve-e2e-error-failures
branch
from
e8e8dd3
to
fd683a6
Compare
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes allow us to have the data to debug and identify the issues: https://github.com/kubernetes-sigs/kubebuilder/actions/runs/10878247989/job/30180826578?pr=4171