🐛 (go/v4): Fix misleading metrics configuration comments in cmd/main.go for metrics certs #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
@varshaprasad96 and @Kavinjsir could you please give a hand on this one? |
grzesuav
reviewed
Oct 30, 2024
| @@ -138,6 +132,16 @@ func main() { | |||
| // can access the metrics endpoint. The RBAC are configured in 'config/rbac/kustomization.yaml'. More info: | |||
| // https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.19.1/pkg/metrics/filters#WithAuthenticationAndAuthorization | |||
| metricsServerOptions.FilterProvider = filters.WithAuthenticationAndAuthorization | |||
|
|
|||
| // TODO(user): If CertDir, CertName, and KeyName are not specified, controller-runtime will automatically | |||
| // generate certificates for the metrics server. While convenient for development and testing, this setup is | |||
grzesuav
approved these changes
Oct 30, 2024
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grzesuav, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@camilamacedo86 Thanks for the PR! Agree with @grzesuav comment on mentioning self-signed certs, also looks like this PR needs to be rebased. |
…ove documentation
camilamacedo86
force-pushed
the
fix-info-comment-main.go
branch
from
8d72576 to
cd15f73
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
added
the
lgtm
camilamacedo86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects and clarifies metrics server TLS setup comments to accurately reflect certificate management.