Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup kubebulder-gen #436

Merged
merged 1 commit into from
Oct 12, 2018
Merged

cleanup kubebulder-gen #436

merged 1 commit into from
Oct 12, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Oct 12, 2018

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2018
@mengqiy mengqiy removed the request for review from DirectXMan12 October 12, 2018 00:20
droot
droot reviewed Oct 12, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except one comment.

build/.goreleaser.yml Outdated
@@ -11,15 +11,6 @@ builds:
- amd64
env:
- CGO_ENABLED=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are moving commands under cmd directly, ldflags for injecting the version will have to be adjusted for the new path for version pkg.

@mengqiy mengqiy force-pushed the cleanup branch 3 times, most recently from 323b378 to 433174c Compare October 12, 2018 00:51
@mengqiy
Copy link
Member Author

mengqiy commented Oct 12, 2018

PTAL

droot
droot reviewed Oct 12, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have a question about releaser file. Also, lets ensure the master build is getting build and do a quick manual test to ensure nothing is broken.

build/.goreleaser.yml
- CGO_ENABLED=0
- main: ./cmd/kubebuilder-gen
binary: kubebuilder-gen
ldflags: -s -X sigs.k8s.io/kubebuilder/cmd/version.kubeBuilderVersion={{.Version}} -X sigs.k8s.io/kubebuilder/cmd/version.gitCommit={{.Commit}} -X sigs.k8s.io/kubebuilder/cmd/version.buildDate={{.Date}} -X sigs.k8s.io/kubebuilder/cmd/version.kubernetesVendorVersion={{.Env.KUBERNETES_VERSION}}
goos:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goarch and env are not needed anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goarch and env are still there.
You may have been confused by the GH code review tool.

I only deleted the kubebuilder-gen piece.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right :)

@mengqiy
Copy link
Member Author

mengqiy commented Oct 12, 2018

I have tried with cloud-build-local. It can build.
It should be able to build on cloud as well. If not, we fix it :)

droot
droot approved these changes Oct 12, 2018
View reviewed changes
build/.goreleaser.yml
- CGO_ENABLED=0
- main: ./cmd/kubebuilder-gen
binary: kubebuilder-gen
ldflags: -s -X sigs.k8s.io/kubebuilder/cmd/version.kubeBuilderVersion={{.Version}} -X sigs.k8s.io/kubebuilder/cmd/version.gitCommit={{.Commit}} -X sigs.k8s.io/kubebuilder/cmd/version.buildDate={{.Date}} -X sigs.k8s.io/kubebuilder/cmd/version.kubernetesVendorVersion={{.Env.KUBERNETES_VERSION}}
goos:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right :)

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit d1fc6f7 into kubernetes-sigs:master Oct 12, 2018
@mengqiy mengqiy deleted the cleanup branch October 12, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @k8s-ci-robot @droot