Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse flags on startup. #466

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Parse flags on startup. #466

merged 1 commit into from
Oct 31, 2018

Conversation

rohitagarwal003
Copy link
Contributor

The generated code had imported flag but was not using it.

Not having flag.Parse() in the beginning was resulting in errors like the following when we hit a glog logged line.
ERROR: logging before flag.Parse: ...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2018
@rohitagarwal003
Copy link
Contributor Author

/cc @droot @mengqiy

@droot
Copy link
Contributor

droot commented Oct 30, 2018

@mengqiy tests are failing because golden files need to be regenerated. Can you help @mindprince with the steps to generate golden files. And, we should also add that to our instructions for contributing

@mengqiy
Copy link
Member

mengqiy commented Oct 30, 2018

we should also add that to our instructions for contributing.

We can probably add the instructions in the error message in the scaffolding tests.

@mindprince Please run ./generated_golden.sh.

@rohitagarwal003
Parse flags on startup.
641bf03 
The generated code had imported flag but was not using it.

Not having flag.Parse() in the beginning was resulting in errors like the following when we hit a glog logged line.
ERROR: logging before flag.Parse: ...
@rohitagarwal003
Copy link
Contributor Author

Done.

@mengqiy
Copy link
Member

mengqiy commented Oct 31, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, mindprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
@k8s-ci-robot k8s-ci-robot merged commit 86180a2 into kubernetes-sigs:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitagarwal003 @droot @mengqiy @k8s-ci-robot