Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow pluralized Kinds when creating resources #48

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Disallow pluralized Kinds when creating resources #48

merged 1 commit into from
Apr 3, 2018

Conversation

pwittrock
Copy link
Contributor

Fixes #32

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2018
Liujingfang1
Liujingfang1 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@Liujingfang1 Liujingfang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwittrock pwittrock merged commit f6d0548 into kubernetes-sigs:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@seans3 seans3 Awaiting requested review from seans3

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwittrock @Liujingfang1 @k8s-ci-robot