Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue in types.ReconcileKey.String() #49

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Fix an issue in types.ReconcileKey.String() #49

merged 1 commit into from
Apr 4, 2018

Commits on Apr 4, 2018

  1. Fix some issues in types.ReconcileKey 

    While trying to determine what key to emit for an element without a
namespace, I looked at types.ReconcileKey which would emit "/name" which
doesn't appear to agree with the rest of the logic in kubebuilder. This
fixes types.ReconcileKey to emit the correct string value if namespace
is empty as well as adds a method to construct the object from a string.
    @briantkennedy
    briantkennedy committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    f53d2c3 View commit details
    Browse the repository at this point in the history