Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 1.12.3 k8s tools #525

Merged
merged 2 commits into from
Jan 9, 2019
Merged

use 1.12.3 k8s tools #525

merged 2 commits into from
Jan 9, 2019

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Dec 11, 2018 •
edited
Loading

Use 1.12.3 k8s binaries. [Action Required for upgrading from kubebuilder <=v1.0.7 to >= v1.0.8] please read #557

@mengqiy mengqiy requested a review from droot December 11, 2018 23:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 12, 2018
@droot
Copy link
Contributor

droot commented Dec 12, 2018

Putting this PR on hold because there is a breaking change in the kube-apiserver-1.12.x wrt. secure-port commandline flag. It doesn't allow turning secure serving off.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2018
@mengqiy
Copy link
Member Author

mengqiy commented Dec 19, 2018

Updated sigs.k8s.io/testing_frameworks to v0.1.1.
Tests should pass this time.

@mengqiy
Copy link
Member Author

mengqiy commented Dec 19, 2018

Tests will keep failing before porting kubernetes-sigs/controller-runtime#257 to vendor 😕

@mengqiy mengqiy closed this Jan 3, 2019
@mengqiy mengqiy reopened this Jan 3, 2019
@mengqiy mengqiy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2019
@mengqiy
Copy link
Member Author

mengqiy commented Jan 4, 2019

PTAL

@mengqiy mengqiy changed the title use 1.12.3 k8s tools for cloud build use 1.12.3 k8s tools Jan 8, 2019
@mengqiy
Copy link
Member Author

mengqiy commented Jan 8, 2019

Updated the commit message and make it point to an issue with more details.
@droot PTAL

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3e2003f into kubernetes-sigs:master Jan 9, 2019
@mengqiy mengqiy deleted the update_release_steps branch January 9, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@droot droot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mengqiy @k8s-ci-robot @droot