Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bug of recursion #72

Merged
merged 1 commit into from
Apr 17, 2018
Merged

fix the bug of recursion #72

merged 1 commit into from
Apr 17, 2018

Conversation

Liujingfang1
Copy link
Contributor

with this change, something like following won't be treated as recursion

type MyKindSpec struct {
    Replica int `json:"replica,omitempty"`
}
type MyKindStatus struct {
    Stat MyKindSpec `json:"stat,omitempty"`
}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2018
pwittrock
pwittrock reviewed Apr 17, 2018
View reviewed changes
cmd/internal/codegen/parse/validation.go
@@ -184,7 +184,7 @@ func (b *APIs) parsePrimitiveValidation(t *types.Type, found sets.String, commen
f = "int32"
case "float", "float32":
n = "number"
f = "loat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@pwittrock pwittrock merged commit d81dcab into kubernetes-sigs:master Apr 17, 2018
@Liujingfang1 Liujingfang1 deleted the found branch May 1, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock pwittrock left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liujingfang1 @pwittrock @k8s-ci-robot