✨ scaffold the webhook builder #816

mengqiy · 2019-06-25T21:24:46Z

Add a new command kubebuilder create webhook for user to scaffold webhook.
Kubebuilder now dynamically register commands based on metadata in PROJECT.
If PROJECT doesn't exist or PROJECT exists with version=2, register
create webhook, but no alpha webhook.
If PROJECT exists and version=1, register alpha webhook but no create webhook

cmd/api.go

DirectXMan12 · 2019-06-25T22:18:01Z

cmd/api.go

@@ -48,6 +48,9 @@ func (o *apiOptions) bindCmdFlags(cmd *cobra.Command) {
 	cmd.Flags().BoolVar(&o.apiScaffolder.DoController, "controller", true,
 		"if set, generate the controller without prompting the user")
 	o.controllerFlag = cmd.Flag("controller")
+	cmd.Flags().BoolVar(&o.apiScaffolder.DoWebhook, "webhook", false,


do we want to differentiate from "manual" webhooks (i.e. not our special defaulting/validating)?

Discussed with Solly offline. We can have something like kubebuilder create webhook --low-level-defaulting --low-level-programmatic-validation for "manual" webhooks if we want to do it in the future.

Filed tracking issue #833

DirectXMan12 · 2019-06-25T22:47:35Z

discussed this a bit more -- we probably want a separate subcommand for enabling this

droot

Change looks good except that we want to have a separate subcommand to enable webhooks.

droot

Mostly looks good. I have a few questions/comments.

cmd/webhook_v2.go

cmd/webhook_v1.go

cmd/webhook_v2.go

pkg/scaffold/v2/main.go

testdata/project-v2/main.go

cmd/webhook_v1.go

cmd/main.go

pkg/scaffold/v2/gomod.go

mengqiy · 2019-06-28T23:45:05Z

PTAL

droot

Looks good, have a minor comments.

Thanks for updating the e2e tests.

cmd/create.go

cmd/main.go

cmd/webhook_v2.go

mengqiy · 2019-07-01T21:04:49Z

PTAL

droot

Looks good. A couple of minor nits.

cmd/create.go

cmd/webhook_v2.go

mengqiy · 2019-07-02T20:26:24Z

Need to update example to add --conversion flag.

I didn't add it in the existing example intentionally, since from our earlier offline discussion. --conversion is for advanced use case and flag description should be good enough.
I can still add a separate example for conversion flag if you believe we need it :)

I don't know why GH doesn't allow me to reply under it. :/

mengqiy · 2019-07-02T23:03:58Z

@droot @DirectXMan12 PTAL

mengqiy · 2019-07-02T23:08:00Z

Travis still has a lot of backlog now: https://www.traviscistatus.com/incidents/g9xm3l02dknv

droot

Looks good to me.

cmd/webhook_v2.go

add a new command `kubebuilder create webhook` to scaffold the webhooks. --defaulting, --imperative-validation and --converison can be used to scaffold mutating, validating and conversion webhooks.

If PROJECT doesn't exist or PROJECT exists with version=2, register `create webhook`, but no `alpha webhook`. If PROJECT exists and version=1, register `alpha webhook` but no `create webhook`

mengqiy · 2019-07-03T18:33:52Z

@droot Should be ready to ship now.

droot · 2019-07-03T18:57:17Z

/lgtm
/approve

droot · 2019-07-03T18:57:34Z

/approve

k8s-ci-robot · 2019-07-03T18:57:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [droot,mengqiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2019

k8s-ci-robot requested review from DirectXMan12 and Liujingfang1 June 25, 2019 21:25

mengqiy requested review from droot and removed request for Liujingfang1 June 25, 2019 21:26

mengqiy added this to Code Awaiting Review in 2.0.0 cross-project tracking Jun 25, 2019

DirectXMan12 requested changes Jun 25, 2019

View reviewed changes

droot reviewed Jun 25, 2019

View reviewed changes

mengqiy force-pushed the webhookbuilder branch 2 times, most recently from 09126a1 to 2438fc5 Compare June 26, 2019 21:05

droot reviewed Jun 27, 2019

View reviewed changes

DirectXMan12 requested changes Jun 27, 2019

View reviewed changes

cmd/webhook_v1.go Outdated Show resolved Hide resolved

cmd/main.go Show resolved Hide resolved

mengqiy force-pushed the webhookbuilder branch from 2438fc5 to b34e3e9 Compare June 28, 2019 23:06

mengqiy changed the title ~~✨ scaffold the webhook builder~~ [WIP] ✨ scaffold the webhook builder Jun 28, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019

mengqiy force-pushed the webhookbuilder branch from b34e3e9 to f5f6768 Compare June 28, 2019 23:38

mengqiy commented Jun 28, 2019

View reviewed changes

pkg/scaffold/v2/gomod.go Outdated Show resolved Hide resolved

mengqiy changed the title ~~[WIP] ✨ scaffold the webhook builder~~ ✨ scaffold the webhook builder Jun 28, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019

mengqiy force-pushed the webhookbuilder branch from f5f6768 to d0ec35f Compare June 28, 2019 23:53

droot reviewed Jul 1, 2019

View reviewed changes

cmd/create.go Outdated Show resolved Hide resolved

cmd/main.go Outdated Show resolved Hide resolved

cmd/main.go Outdated Show resolved Hide resolved

cmd/webhook_v2.go Show resolved Hide resolved

droot mentioned this pull request Jul 1, 2019

Audit KB subcommands for v2 #824

Closed

droot reviewed Jul 2, 2019

View reviewed changes

cmd/create.go Show resolved Hide resolved

cmd/webhook_v2.go Show resolved Hide resolved

mengqiy force-pushed the webhookbuilder branch from 5df08d2 to 906e8a6 Compare July 2, 2019 22:44

mengqiy force-pushed the webhookbuilder branch from 906e8a6 to 396a014 Compare July 2, 2019 22:49

droot reviewed Jul 3, 2019

View reviewed changes

cmd/webhook_v2.go Outdated Show resolved Hide resolved

cmd/webhook_v2.go Outdated Show resolved Hide resolved

mengqiy mentioned this pull request Jul 3, 2019

Support low level webhook scaffolding #833

Closed

Mengqi Yu added 2 commits July 3, 2019 11:32

✨ scaffold the webhook builder

1afe5ad

add a new command `kubebuilder create webhook` to scaffold the webhooks. --defaulting, --imperative-validation and --converison can be used to scaffold mutating, validating and conversion webhooks.

✨ dynamically register commands based on PROJECT version.

f0a987e

If PROJECT doesn't exist or PROJECT exists with version=2, register `create webhook`, but no `alpha webhook`. If PROJECT exists and version=1, register `alpha webhook` but no `create webhook`

mengqiy force-pushed the webhookbuilder branch from 396a014 to f0a987e Compare July 3, 2019 18:33

k8s-ci-robot assigned droot Jul 3, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2019

k8s-ci-robot merged commit 285b0bc into kubernetes-sigs:master Jul 3, 2019

2.0.0 cross-project tracking automation moved this from Code Awaiting Review to Done Jul 3, 2019

mengqiy deleted the webhookbuilder branch July 3, 2019 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ scaffold the webhook builder #816

✨ scaffold the webhook builder #816

mengqiy commented Jun 25, 2019 •

edited

Loading

DirectXMan12 Jun 25, 2019

mengqiy Jul 2, 2019

mengqiy Jul 3, 2019

DirectXMan12 commented Jun 25, 2019

droot left a comment

droot left a comment

mengqiy commented Jun 28, 2019

droot left a comment

mengqiy commented Jul 1, 2019

droot left a comment

mengqiy commented Jul 2, 2019

mengqiy commented Jul 2, 2019

mengqiy commented Jul 2, 2019

droot left a comment

mengqiy commented Jul 3, 2019 •

edited

Loading

droot commented Jul 3, 2019

droot commented Jul 3, 2019

k8s-ci-robot commented Jul 3, 2019

✨ scaffold the webhook builder #816

✨ scaffold the webhook builder #816

Conversation

mengqiy commented Jun 25, 2019 • edited Loading

DirectXMan12 Jun 25, 2019

Choose a reason for hiding this comment

mengqiy Jul 2, 2019

Choose a reason for hiding this comment

mengqiy Jul 3, 2019

Choose a reason for hiding this comment

DirectXMan12 commented Jun 25, 2019

droot left a comment

Choose a reason for hiding this comment

droot left a comment

Choose a reason for hiding this comment

mengqiy commented Jun 28, 2019

droot left a comment

Choose a reason for hiding this comment

mengqiy commented Jul 1, 2019

droot left a comment

Choose a reason for hiding this comment

mengqiy commented Jul 2, 2019

mengqiy commented Jul 2, 2019

mengqiy commented Jul 2, 2019

droot left a comment

Choose a reason for hiding this comment

mengqiy commented Jul 3, 2019 • edited Loading

droot commented Jul 3, 2019

droot commented Jul 3, 2019

k8s-ci-robot commented Jul 3, 2019

mengqiy commented Jun 25, 2019 •

edited

Loading

mengqiy commented Jul 3, 2019 •

edited

Loading