Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis integration #95

Merged
merged 1 commit into from
Apr 26, 2018
Merged

travis integration #95

merged 1 commit into from
Apr 26, 2018

Conversation

droot
Copy link
Contributor

@droot droot commented Apr 26, 2018

No description provided.

@droot droot requested a review from pwittrock April 26, 2018 23:03
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2018
@droot droot requested a review from Liujingfang1 April 26, 2018 23:04
Liujingfang1
Liujingfang1 approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@Liujingfang1 Liujingfang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for adding the test.

@droot droot merged commit 02e01e3 into kubernetes-sigs:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@droot @Liujingfang1 @k8s-ci-robot