Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

optimize chart readme #1328

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

huiwq1990
Copy link
Contributor

What this PR does / why we need it:

  1. As upgrade CustomResourceDefinition in Transition from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1 #1296 , kubefed only support 1.16+
  2. controllermanager docker image split into controller image and webhook image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 15, 2020
@makkes
Copy link
Contributor

makkes commented Dec 15, 2020

/lgtm

Thanks a lot, @huiwq1990.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
Copy link
Contributor

@irfanurrehman irfanurrehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huiwq1990
I might be missing something, but it appears like there are duplicates. Please check and let me know.

| controllermanager.webhook.repository | Repo of the KubeFed image. | quay.io/kubernetes-multicluster |
| controllermanager.webhook.image | Name of the KubeFed image. | kubefed |
| controllermanager.webhook.tag | Tag of the KubeFed image. | canary |
| controllermanager.controller.replicaCount | Number of replicas for KubeFed controller manager. | 1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a repeat of line 107?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i have fix them.

| controllermanager.webhook.image | Name of the KubeFed image. | kubefed |
| controllermanager.webhook.tag | Tag of the KubeFed image. | canary |
| controllermanager.controller.replicaCount | Number of replicas for KubeFed controller manager. | 1 |
| controllermanager.controller.imagePullPolicy | Image pull policy. | IfNotPresent |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean controllermanager.webhook.imagePullPolicy?

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@huiwq1990
Copy link
Contributor Author

@irfanurrehman I have recheck my pr, and fix them.

@makkes
Copy link
Contributor

makkes commented Dec 15, 2020

We should put all options in (alphabetic?) order but that can be done in a subsequent PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@huiwq1990
Copy link
Contributor Author

I prefer organize them by kubefed’s module(webhook,controller). User know how to config them at first glance.

@irfanurrehman
Copy link
Contributor

Thanks @huiwq1990
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, irfanurrehman, makkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 57dc389 into kubernetes-retired:master Dec 16, 2020
@huiwq1990 huiwq1990 deleted the fix-char-readme branch December 21, 2020 02:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants