The committers listed above are authorized under a signed CLA.

• ✅ login: oboudry-mvp / name: Olivier Boudry (21b9589)

Welcome @oboudry-mvp!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @oboudry-mvp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale

/lgtm
/approve
/retest-failed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oboudry-mvp, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

You need to rebase your branch, the CI setup has changed and the docker-machine executor is no longer available on the CI cluster

New changes are detected. LGTM label has been removed.

Hi VannTen, If I'm not mistaken, it's been rebased.

@VannTen not sure how to rebase my PR, I think I've made the error of amending the master branch, not a separate branch. Shall I recreate the PR or is there something I can do to fix it ?

Oh you pushed on the master branch of your fork, I see what kind of problems you could have.
You could do somehting like that

$ git fetch <upstream-remote (github.com/kubernetes-sigs/kubespray)> # update the local copy of the main repo
$ git rebase upstream/master (from your branch) # replay your branch on top of upstream/master
$ git push --force # push to your fork's master

(It's generally a good idea to avoid using the 'master' branch from your fork for doing PRs, it's generally confusing.

@VannTen Did the push with --force and it looks like it worked. Yes creating a branch would have been better. Thanks for your help!