-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flatcar bug #11268 missing default value for ansible_interpreter_python_fallback variable #11270
Conversation
|
Welcome @oboudry-mvp! |
Hi @oboudry-mvp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oboudry-mvp, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You need to rebase your branch, the CI setup has changed and the docker-machine executor is no longer available on the CI cluster |
Hi VannTen, If I'm not mistaken, it's been rebased. |
@VannTen not sure how to rebase my PR, I think I've made the error of amending the master branch, not a separate branch. Shall I recreate the PR or is there something I can do to fix it ? |
Oh you pushed on the master branch of your fork, I see what kind of problems you could have. $ git fetch <upstream-remote (github.com/kubernetes-sigs/kubespray)> # update the local copy of the main repo
$ git rebase upstream/master (from your branch) # replay your branch on top of upstream/master
$ git push --force # push to your fork's master (It's generally a good idea to avoid using the 'master' branch from your fork for doing PRs, it's generally confusing. |
…le_interpreter_python_fallback variable
@VannTen Did the push with --force and it looks like it worked. Yes creating a branch would have been better. Thanks for your help! |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
In some scenarios, a kubespray upgrade of a Flatcar based cluster fails with v2.25.0. This is due to the variable
ansible_interpreter_python_fallback
being referenced in fileroles/bootstrap-os/tasks/flatcar.yml
also this variable may not exist. This PR sets a default value of [] (empty list) in the case theansible_interpreter_python_fallback
variable does not exists.Which issue(s) this PR fixes:
Fixes #11268
Special notes for your reviewer:
Does this PR introduce a user-facing change?: