-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new OpenStack Cloud for terraform #10910
Conversation
|
Hi @DragomirAlin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm
|
Hi @MrFreezeex , Could you take a look at this PR? |
Hey @DragomirAlin, I am not a kubespray approver so me approving this PR won't help getting it merged tbh but from what I can see it looks good! |
/ok-to-test |
/assign @holmsten |
@VannTen: GitHub didn't allow me to assign the following users: holmsten. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DragomirAlin Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DragomirAlin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Add a new OpenStack cloud for terraform. Kubespray compatibility can be checked here Kubespray with Cloudify
Does this PR introduce a user-facing change?: