Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new OpenStack Cloud for terraform #10910

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

DragomirAlin
Copy link
Contributor

@DragomirAlin DragomirAlin commented Feb 10, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Add a new OpenStack cloud for terraform. Kubespray compatibility can be checked here Kubespray with Cloudify

Does this PR introduce a user-facing change?:

Add new OpenStack Cloud for terraform

Copy link

linux-foundation-easycla bot commented Feb 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DragomirAlin / name: Alin Dragomir (68d9024)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @DragomirAlin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 10, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 11, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2024
@DragomirAlin
Copy link
Contributor Author

Hi @MrFreezeex , Could you take a look at this PR?

@MrFreezeex
Copy link
Member

MrFreezeex commented Feb 16, 2024

Hi @MrFreezeex , Could you take a look at this PR?

Hey @DragomirAlin, I am not a kubespray approver so me approving this PR won't help getting it merged tbh but from what I can see it looks good!

@MrFreezeex
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 16, 2024

/assign @holmsten

@k8s-ci-robot
Copy link
Contributor

@VannTen: GitHub didn't allow me to assign the following users: holmsten.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @holmsten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DragomirAlin Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DragomirAlin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit b34b7e0 into kubernetes-sigs:master Feb 19, 2024
65 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
@mzaian mzaian added the kind/documentation Categorizes issue or PR as related to documentation. label May 6, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants