Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Add hashes for kubernetes 1.29.7, 1.28.[11-12] #11407

Merged

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Jul 31, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
Upgrade kubernetes versions
Add hashes for kubernetes 1.29.7, 1.28.[11-12]

Does this PR introduce a user-facing change?:

Add hashes for kubernetes 1.29.7, 1.28.[11-12]

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@mzaian
Copy link
Contributor Author

mzaian commented Jul 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 31, 2024
@yankay
Copy link
Member

yankay commented Jul 31, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8d497b4 into kubernetes-sigs:master Jul 31, 2024
39 checks passed
@mzaian
Copy link
Contributor Author

mzaian commented Jul 31, 2024

/cherrypick release-2.25

@k8s-infra-cherrypick-robot

@mzaian: #11407 failed to apply on top of branch "release-2.25":

Applying: Add hashes for kubernetes 1.29.7, 1.28.[11-12]
Using index info to reconstruct a base tree...
M	roles/kubespray-defaults/defaults/main/checksums.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/kubespray-defaults/defaults/main/checksums.yml
CONFLICT (content): Merge conflict in roles/kubespray-defaults/defaults/main/checksums.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add hashes for kubernetes 1.29.7, 1.28.[11-12]
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay yankay mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants