Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested on Debian 13 trixie with ansible version 2.18.1 #11935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gratuxri
Copy link

Fix: running from Debian 13

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 29, 2025
Copy link

linux-foundation-easycla bot commented Jan 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gratuxri / name: Juri Grabowski (91a92c6)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gratuxri
Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @gratuxri!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @gratuxri. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 29, 2025
@VannTen
Copy link
Contributor

VannTen commented Jan 30, 2025

xref #11924

@tico88612
Copy link
Member

Hi @gratuxri, thanks for your PR.
But Debian 13 hasn’t been released yet, as they are still handling the Ansible upgrade for some reason. (#11872 & #11519)
I’d like to ask if there is a specific reason for upgrading ansible-core to 2.18? If possible, could you help us test 2.17?

@gratuxri
Copy link
Author

gratuxri commented Feb 3, 2025

@tico88612 : on debian stable 13 (bookworm) I have ansible-core version 2.14.18 and it was not possible to deploy with this playbook. Simple possible solution was to go forward and upgrade ansible-core to the next possible version and make changes, like purposed in this PR. The next possible version was 2.18.1 from debian trixie and pinning ansible packages to trixie until it release. It's planned to do the next freeze on 15. march, so it's managable for me for the next halfyear. Here is an overview of ansible packages in debian:
https://packages.debian.org/search?keywords=ansible-core&searchon=names&suite=all&section=all
Let me know, how can I help with tests?!

@tico88612
Copy link
Member

on debian stable 13 (bookworm) I have ansible-core version 2.14.18 and it was not possible to deploy with this playbook.

Our ansible-core version 2.16.4 or above, not 2.14.18, the pre-check will be failed. (Look at playbooks/ansible_version.yml)

Simple possible solution was to go forward and upgrade ansible-core to the next possible version and make changes, like purposed in this PR.

On my previous comment, we have other OS to support.
According to ansible's documentation, if we upgrade ansible-core to 2.18.2, the target nodes need Python 3.8.

I'm not sure other OS's pre-install Python version, but to do this at this stage (before remove the RHEL8-based CI), the CI will only fail and we can't merge your PR.

BTW, according to Debian's release note, I think ansible-core 2.17.x is no problem in Debian 13.

Let me know, how can I help with tests?!

I was hoping to wait for Debian 13 to become stable (but it looks like it's still in TBA), but if you want to test it locally, you can modify the Vagrantfile and use Vagrant.

FYI: https://kubespray.io/#/docs/developers/vagrant

@yankay
Copy link
Member

yankay commented Feb 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2025
@yankay
Copy link
Member

yankay commented Feb 6, 2025

It needs to rebase the master branch to pass the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants