Fix quotations in dhclient hooks

[kyrbrbik]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #11930

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix broken dhclient hooks when using resolvconf

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: kyrbrbik / name: Jan Breitkopf (0a876ec)

[k8s-ci-robot]

Welcome @kyrbrbik!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kyrbrbik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyrbrbik
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tico88612]

/ok-to-test

[kyrbrbik]

/retest

[yankay]

It needs to rebase the master branch to pass the CI.

[kyrbrbik]

Thanks, looks good now

[VannTen]

why join('","') ?

From the format you have in the issue there should only be quote around the the whole list, not each item, right ?

# Ansible entries BEGIN
supersede domain-name-servers 169.254.25.10,1.1.1.1,8.8.8.8;
supersede domain-name "cluster.local";
supersede domain-search "default.svc.cluster.local,svc.cluster.local";
# Ansible entries END

[kyrbrbik]

Yeah you're correct but that's probably a mistake made by me in the original issue. Looking at a cluster that has been installed with kubespray before this broke, the domains are quoted on each item.

Can't really test if it can be quoted around the whole list right now as the only cluster that was affected by this issue is our production one that I would rather not break.

[VannTen]

Good enough for me then. /lgtm