-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [containerd] Support containerd, Update config.toml.j2 to support containerd >= 2.0.X syntax change #11949
base: master
Are you sure you want to change the base?
Conversation
…t containerd >= 2.0.X syntax change
…t containerd >= 2.0.X syntax change 2
…t containerd >= 2.0.X syntax changes
…t containerd >= 2.0.X syntax changes
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jeikeibnaa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jeikeibnaa! |
Hi @jeikeibnaa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related pull request: #11845 |
/ok-to-test |
It needs to rebase the master branch to pass the CI. |
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please resolve these problems:
|
Configs in containerd 2.x and 1.x have significant differences(see configuration comparison between 1.x and 2.x), example shown as sandbox image location from 1.x to 2.x:
So instead of messing configurations of two versions, if it's better to use two separating jinja2 files to template their own configurations? |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #11947
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change?: