Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When running ./manage-offline-container-images.sh register using Podman, retrieving the image ID fails and the script stops. #11961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DearJey
Copy link

@DearJey DearJey commented Feb 10, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

When I run ./manage-offline-container-images.sh register to register an image in the container registry using Podman, the following error occurs and the script stops.

Getting image source signatures
Copying blob b972131a1dcc skipped: already exists
Copying blob 011b303988d2 skipped: already exists
Copying blob a4be933f3ee0 skipped: already exists
Copying config 3fe402881a done   |
Writing manifest to image destination
Failed to get image_id for file docker.io-mirantis-k8s-netchecker-server-v1.2.2.tar

I checked the error contents, it seems that the acquisition of image_id has failed.

  • The relevant part of the script (manage-offline-container-images.sh)
image_id=$(${runtime} image inspect ${org_image} | grep "\"Id\":" | awk -F: '{print $3}'| sed s/'\",'//)

In offline deployment, we can use Docker, Podman, and nerdctl as container runtimes.
The method for outputting the image ID is the same for Docker and nerdctl, but Podman uses a different method, so the method to obtain the ID needs to be modified separately for Podman and the others.

  • Podman
# podman image inspect <image>
          "Id": "XXX",
  • Docker
# docker image inspect <image>
        "Id": "sha256:XXX",
  • nerdctl
# nerdctl image inspect <image>
        "Id": "sha256:XXX",

Which issue(s) this PR fixes:

Fixes #11865

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: When running `./manage-offline-container-images.sh register` with using Podman, getting the image_id fails and the script is interrupted.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DearJey
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @DearJey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2025
@tico88612
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2025
@tico88612
Copy link
Member

/retest-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
3 participants