fix: A timeout occurs when running the offline deployment script using Podman.

[DearJey]

What type of PR is this?
/kind bug

What this PR does / why we need it:

When trying to create an Nginx container as a file server, the container fails to start due to a timeout when using manage-offline-files.sh.

Trying to pull docker.io/library/nginx:alpine...
WARN[0065] Failed, retrying in 1s ... (1/3). Error: initializing source docker://nginx:alpine: pinging container registry registry-1.docker.io: Get "https://registry-1.docker.io/v2/": dial tcp 54.198.86.24:443: i/o timeout 
WARN[0126] Failed, retrying in 1s ... (2/3). Error: initializing source docker://nginx:alpine: pinging container registry registry-1.docker.io: Get "https://registry-1.docker.io/v2/": dial tcp 54.198.86.24:443: i/o timeout 
WARN[0187] Failed, retrying in 1s ... (3/3). Error: initializing source docker://nginx:alpine: pinging container registry registry-1.docker.io: Get "https://registry-1.docker.io/v2/": dial tcp 54.227.20.253:443: i/o timeout 
Error: initializing source docker://nginx:alpine: pinging container registry registry-1.docker.io: Get "https://registry-1.docker.io/v2/": dial tcp 54.236.113.205:443: i/o timeout

When I checked the script file(manage-offline-files.sh), I found git run was executed with sudo.

• manage-offline-files.sh

"${runtime}" container inspect nginx >/dev/null 2>&1
if [ $? -ne 0 ]; then
    sudo "${runtime}" run \
        --restart=always -d -p ${NGINX_PORT}:80 \
        --volume "${OFFLINE_FILES_DIR}":/usr/share/nginx/html/download \
        --volume "${CURRENT_DIR}"/nginx.conf:/etc/nginx/nginx.conf \
        --name nginx nginx:alpine
fi

When acquiring an image with Podman, it goes through a proxy, but sudo is attached, so the environment variables are not inherited and resulting in a timeout.

Therefore, adding the -E option to the run pull command in the script.

• manage-offline-files.sh
• manage-offline-container-images.sh

Which issue(s) this PR fixes:

Fixes #11866

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: A timeout occurs when running the offline deployment script using Podman.

[k8s-ci-robot]

Hi @DearJey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[0ekk]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DearJey, r0b2g1t
Once this PR has been reviewed and has the lgtm label, please assign cristicalin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment