Fix: Using the ./manage-offline-container-images.sh register command does not create a new container but registers the image in the existing container registry.

[DearJey]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Since I have already created a container registry, I would like to register the image there. However, when I try to register the image using the command below, a new container named 'registry' is created, and the image is registered there instead.

# export DESTINATION_REGISTRY=192.168.122.155:5000 #Specify an existing container registry
# ./manage-offline-container-images.sh register

• check containers

# podman ps -a
CONTAINER ID  IMAGE                              COMMAND               CREATED             STATUS       PORTS                   NAMES
d90b84b7c726  docker.io/library/registry:2.8.2   /etc/docker/regis...  15 hours ago        Up 15 hours  0.0.0.0:5000->5000/tcp  docker-distribution
b2ab51819745  docker.io/library/nginx:alpine     nginx -g daemon o...  15 hours ago        Up 15 hours  0.0.0.0:8080->80/tcp    nginx
61997afcca9e  docker.io/library/registry:latest  /etc/docker/regis...  About a minute ago  Created      0.0.0.0:5000->5000/tcp  registry

When I checked the script file (manage-offline-container-images.sh), it seemed that the container registry was being created using the following steps.

if [ "${create_registry}" ]; then
		sudo ${runtime} load -i ${IMAGE_DIR}/registry-latest.tar
		set +e

		sudo ${runtime} container inspect registry >/dev/null 2>&1
		if [ $? -ne 0 ]; then
			sudo ${runtime} run --restart=always -d -p "${REGISTRY_PORT}":"${REGISTRY_PORT}" --name registry registry:latest
		fi
		set -e
	fi

The create_registry above is determined by the following.

function register_container_images() {
	create_registry=false
	REGISTRY_PORT=${REGISTRY_PORT:-"5000"}

	if [ -z "${DESTINATION_REGISTRY}" ]; then
		echo "DESTINATION_REGISTRY not set, will create local registry"
		create_registry=true
		DESTINATION_REGISTRY="$(hostname):${REGISTRY_PORT}"
	fi
	echo "Images will be pushed to ${DESTINATION_REGISTRY}"

Originally, if a registry already exists and you want to push the image there, you need to set the registry address in REGISTRY_PORT. I understand that if REGISTRY_PORT is not set, it means a container registry is created in the local registry and the image is pushed there.

Based on the above settings, it is correct to not execute the procedure if create_registry is false, but to execute it if it is true. However, as shown in if [ "${create_registry}" ]; then, the procedure is designed to create a registry if the create_registry variable is set, meaning a local registry is created regardless of whether a push destination container registry is specified or not.

To fix the issue, the following changes are necessary.

if ${create_registry}; then

Which issue(s) this PR fixes:

Fixes #11867

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix: Using the ./manage-offline-container-images.sh register command does not create a new container but registers the image in the existing container registry.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DearJey
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @DearJey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test