Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add certificate authority file #3433

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

ankitcharolia
Copy link
Contributor

This PR is fixing the BUG #3432
Please review it.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2018
@ant31
Copy link
Contributor

ant31 commented Oct 2, 2018

Does it solve your issue, have you tested? why the CI clusters are not failing on this task?

you need the sign the CLA

@ant31
Copy link
Contributor

ant31 commented Oct 2, 2018

ci check this

@ankitcharolia
Copy link
Contributor Author

ankitcharolia commented Oct 2, 2018

@ant31 This fixes issues mentioned in #3432 and playbook runs through.

This PR also fixes backing up etcd v3 data.

I have already signed CLA. Please have a look.

@ant31
Copy link
Contributor

ant31 commented Oct 2, 2018

/check-cla

@ant31
Copy link
Contributor

ant31 commented Oct 2, 2018

you commited with: ankitcharolia1991
You must sign the cla with the same email address than the commit

@ankitcharolia1991
Copy link

/check-cla

1 similar comment
@ankitcharolia1991
Copy link

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 2, 2018
@ankitcharolia1991
Copy link

@ant31 Hey I have signed CLA. Please verify it and merge PR if all look good.

Thank you

@ant31
Copy link
Contributor

ant31 commented Nov 2, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9c83551 into kubernetes-sigs:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants