Blocksize for calico default pool should be configurable #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mirwan, riverzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Oct 2, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray: clean up document (kubernetes-sigs#5214) Apply workaround for NetworkManager and calico (kubernetes-sigs#5230) Switch to Kubernetes v1.16.0 (kubernetes-sigs#5189) fix digital rebar url (kubernetes-sigs#5223) Add docs for TF vars introduced PR 4239 (kubernetes-sigs#5201) clean-up doc,spelling mistakes (kubernetes-sigs#5206) Updated kubectl.sh (kubernetes-sigs#5156) MetalLB: fail if kube_proxy_strict_arp is false (kubernetes-sigs#5180) fix-up some spelling mistakes (kubernetes-sigs#5202) generate kubeadm download image list with options useHyperKubeImage (kubernetes-sigs#5203) Customize host root volume size by Terrafrom provisioning (kubernetes-sigs#4239) Blocksize for calico default pool should be configurable (kubernetes-sigs#5198) fix-typo (kubernetes-sigs#5199)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When using multiple pools (within the podSubnet), the blocksize is not necessarily the same as the
kube_network_node_prefix.This PR introduces the variable
calico_pool_blocksize(which defaults tokube_network_node_prefix) that is used in the calico pool definition.Which issue(s) this PR fixes:
None that I found/reported
Does this PR introduce a user-facing change?:
No