-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update docs to match actuall required settings to perform an unsafe u… #5609
Conversation
…pgrade using cluster.yml playbook. Relates to kubernetes-sigs#4736 and kubernetes-sigs#4139
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Flowkap! |
Ok. It might have been my missing secondary email (added to github mailing list as well) This comment should retrigger the cla check bot right? It did ^^ |
Thanks a lot for this patch! I walked through the code a while ago but did not find the right argument to trigger this. |
I mean if its intentional the doc update should suffice. ALthough to be honest i'm, not sure why cluster.yml would actually do everything else but this. Didn't find an explanation for it. Maybe its generally not suggested to upgrade the cluster internal services non gracefully. Which might be fine. Anyway with the suggested doc change one can at least use the cluster.yml as its described roughly. :) |
Thank you for your contribution /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Flowkap, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pgrade using cluster.yml playbook. Relates to kubernetes-sigs#4736 and kubernetes-sigs#4139 (kubernetes-sigs#5609)
Update docs to match actuall required settings to perform an unsafe upgrade using cluster.yml playbook.
Relates to:
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4736
Fixes #4139