Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update docs to match actuall required settings to perform an unsafe u… #5609

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

Flowkap
Copy link
Contributor

@Flowkap Flowkap commented Feb 7, 2020

Update docs to match actuall required settings to perform an unsafe upgrade using cluster.yml playbook.

Relates to:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4736
Fixes #4139

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Flowkap!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2020
@Flowkap Flowkap changed the title UPdate docs to match actuall required settings to perform an unsafe u… [docs] Update docs to match actuall required settings to perform an unsafe u… Feb 7, 2020
@Flowkap
Copy link
Contributor Author

Flowkap commented Feb 7, 2020

Ok. It might have been my missing secondary email (added to github mailing list as well) This comment should retrigger the cla check bot right?


It did ^^

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2020
@jklare
Copy link

jklare commented Feb 7, 2020

Thanks a lot for this patch! I walked through the code a while ago but did not find the right argument to trigger this.

@Flowkap
Copy link
Contributor Author

Flowkap commented Feb 7, 2020

Thanks a lot for this patch! I walked through the code a while ago but did not find the right argument to trigger this.

I mean if its intentional the doc update should suffice. ALthough to be honest i'm, not sure why cluster.yml would actually do everything else but this. Didn't find an explanation for it. Maybe its generally not suggested to upgrade the cluster internal services non gracefully. Which might be fine. Anyway with the suggested doc change one can at least use the cluster.yml as its described roughly. :)

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 17, 2020

Thank you for your contribution

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Flowkap, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6401902 into kubernetes-sigs:master Feb 17, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants