Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update multus to 3.4 #5701

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

crandles
Copy link
Contributor

@crandles crandles commented Mar 1, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
This updates multus to 3.4.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade to multus 3.4

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from holmsten and LuckySB March 1, 2020 17:23
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 2, 2020
@crandles
Copy link
Contributor Author

crandles commented Mar 2, 2020

/assign @LuckySB

@LuckySB
Copy link
Contributor

LuckySB commented Mar 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crandles, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@crandles crandles force-pushed the update-multus branch 2 times, most recently from 2cce29e to 9bd78bd Compare March 8, 2020 04:55
Signed-off-by: Chris Randles <randles.chris@gmail.com>
@crandles
Copy link
Contributor Author

crandles commented Mar 8, 2020

Had a couple issues (typo / jinja spacing). I've tried this with weave and calico, and it seems to work.

@LuckySB
Copy link
Contributor

LuckySB commented Mar 10, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@LuckySB: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LuckySB
Copy link
Contributor

LuckySB commented Mar 10, 2020

/reopen

for restart ci tests

@k8s-ci-robot k8s-ci-robot reopened this Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

@LuckySB: Reopened this PR.

In response to this:

/reopen

for restart ci tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 11, 2020

Any input on this @jiejhih ?

@LexCC
Copy link

LexCC commented Mar 13, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jiejhih: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 71c8568 into kubernetes-sigs:master Mar 13, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 14, 2020
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants