Explicitly set ETCDCTL_API and use ETCDCTL_ENDPOINTS #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
Miouge1
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
Miouge1
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
floryut
reviewed
Jun 26, 2020
| register: member_add_result | ||
| until: member_add_result.rc == 0 | ||
| retries: "{{ etcd_retries }}" | ||
| delay: "{{ retry_stagger | random + 3 }}" | ||
| environment: | ||
| ETCDCTL_ENDPOINTS: "{{ etcd_events_access_addresses }}" |
There was a problem hiding this comment.
Why didn't you set ETCDCTL_API here ?
There was a problem hiding this comment.
Missed it, adding that in latest commit.
floryut
reviewed
Jun 26, 2020
| register: etcd_events_member_in_cluster | ||
| changed_when: false | ||
| check_mode: no | ||
| tags: | ||
| - facts | ||
| environment: | ||
| ETCDCTL_ENDPOINTS: "{{ etcd_events_access_addresses }}" |
There was a problem hiding this comment.
Missed it, adding that in latest commit.
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@Miouge1 i have two question
command return Can you check also ? PS: i trigger manual ci job https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/617098515 to check with |
|
@LuckySB I do not update the etcd version in this PR. I'm trying to split the work in several steps to make things easier. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Jul 1, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: Patch Calico for V3.14.0 missing CR and CRD (kubernetes-sigs#6276) Explicitly set ETCDCTL_API and use ETCDCTL_ENDPOINTS (kubernetes-sigs#6327) Add additional metadata configuration options to external Openstack CCM (kubernetes-sigs#6338) (kubernetes-sigs#6339)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In etcd 3.4
ETCDCTL_APIdefaults to 3 instead of 2, therefore adding explicitETCDCTL_API: 3should help until we upgrade.Using
ETCDCTL_ENDPOINTSinstead of--endpointsto make it more consistent