Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ovn4nfv-k8s-plugin in kubespray #6381

Merged
merged 1 commit into from
Jul 31, 2020
Merged

adding ovn4nfv-k8s-plugin in kubespray #6381

merged 1 commit into from
Jul 31, 2020

Conversation

rkamudhan
Copy link
Contributor

Signed-off-by: Kuralamudhan Ramakrishnan kuralamudhan.ramakrishnan@intel.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
This provides an easier way to install ovn4nfv-k8s-plugins as the network plugin in Kubespray. ovn4nfv-k8s-plugins is the network controller, OVS agent and CNI server to offer basic SFC and OVN overlay networking.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add kube_network_plugin: ovn4nfv to deploy ovn4nfv-k8s-plugin as network plugin in kubespray

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @rkamudhan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut July 7, 2020 22:46
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2020
@rkamudhan rkamudhan force-pushed the dev/ovn4nfv branch 4 times, most recently from 987ffe5 to 97ec639 Compare July 10, 2020 05:22
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2020
@rkamudhan
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@rkamudhan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rkamudhan
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@rkamudhan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rkamudhan
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@rkamudhan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rkamudhan rkamudhan force-pushed the dev/ovn4nfv branch 3 times, most recently from a6fa07d to c306c89 Compare July 13, 2020 15:31
@rkamudhan
Copy link
Contributor Author

rkamudhan commented Jul 13, 2020 •
edited
Loading

@EppO @floryut - Packet deployment for the ovn4nfv is working fine. But randomly current CI build packet_centos7-calico-ha-once-localhost and packet_fedora30-weave are failing because of ssh connectivity with VM. It is not related to our patch.

I also see the same in the previous CI build with packet_fedora31-flannel failing. Could you please help to solve this issue. Can you issue re-test?

@floryut
Copy link
Member

floryut commented Jul 17, 2020

@EppO @floryut - Packet deployment for the ovn4nfv is working fine. But randomly current CI build packet_centos7-calico-ha-once-localhost and packet_fedora30-weave are failing because of ssh connectivity with VM. It is not related to our patch.

I also see the same in the previous CI build with packet_fedora31-flannel failing. Could you please help to solve this issue. Can you issue re-test?

All good, sometimes CI is a bit hectic
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2020
@floryut
Copy link
Member

floryut commented Jul 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2020
@floryut
Copy link
Member

floryut commented Jul 17, 2020 •
edited
Loading

/lgtm cancel

@rkamudhan Thank you for this btw, but can you add the verison in README.md ?

Also it seems you didn't add this to the pre-download images list, is it intended ?

Also a quick doc about this network plugin would be nice to have I'd say :)

@rkamudhan rkamudhan force-pushed the dev/ovn4nfv branch 2 times, most recently from 23145f9 to 346cc33 Compare July 17, 2020 17:37
@rkamudhan
Copy link
Contributor Author

@floryut Thanks for the quick response. I have added the changes is README.md, pre-download image list and doc.

Could you please re-issue retest? The packet deployments are failing because of ssh connectivity with VMs.

@rkamudhan
Copy link
Contributor Author

@floryut Thanks for re issuing the test. Please let me know, if the PR is good to go.

@floryut
Copy link
Member

floryut commented Jul 21, 2020

@floryut Thanks for re issuing the test. Please let me know, if the PR is good to go.

Looks good to me :)
WDYT @Miouge1 ?

@rkamudhan
Copy link
Contributor Author

@floryut Thanks for re issuing the test. Please let me know, if the PR is good to go.

Looks good to me :)
WDYT @Miouge1 ?

Thanks for giving thumb up. Please let me know if any more changes required. If so I will make the required changes.

@rkamudhan rkamudhan force-pushed the dev/ovn4nfv branch 2 times, most recently from 9ded7ce to 98ac136 Compare July 28, 2020 20:21
@rkamudhan
Copy link
Contributor Author

@Miouge1 @floryut Added the ansible lint E305 fix as well. Please let me know the PR is good to go.

@rkamudhan
Copy link
Contributor Author

@floryut @Miouge1 Could you please re-issuing retest for the failing ci test.

@rkamudhan
Copy link
Contributor Author

@floryut @Miouge1 Could you please re-issuing retest for the failing ci test.

@floryut @Miouge1 Thanks for issuing the retest. Could you please re-issue retest again? The packet deployments are failing because of ssh connectivity with VMs in the CI pipeline for the Deploy-part2 in the pipeline

@rkamudhan
Copy link
Contributor Author

@floryut @Miouge1 Thanks for reissuing the test. Please let me know if any more changes required. Hope the PR is good to merge.

@floryut
Copy link
Member

floryut commented Jul 30, 2020

All good to me but instead of adding back a noqa please fix it, @Miouge1 took a lot of time to tackle most of them

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2020
@rkamudhan rkamudhan force-pushed the dev/ovn4nfv branch 2 times, most recently from e8cee2d to a423f39 Compare July 31, 2020 07:30
@rkamudhan
adding ovn4nfv in kubespray
a423f39 
Signed-off-by: Kuralamudhan Ramakrishnan <kuralamudhan.ramakrishnan@intel.com>
@rkamudhan
Copy link
Contributor Author

All good to me but instead of adding back a noqa please fix it, @Miouge1 took a lot of time to tackle most of them

@floryut I removed the noqa from the code, I took refer from the @Miouge1 commits. Please let me know if any more changes are required.

@floryut
Copy link
Member

floryut commented Jul 31, 2020

Fine by me, thank you
/lgtm
/assign @Miouge1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 31, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, rkamudhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 90e5f8f into kubernetes-sigs:master Jul 31, 2020
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 17, 2020
@rkamudhan @LuckySB
adding ovn4nfv in kubespray (kubernetes-sigs#6381)
da93e63 
Signed-off-by: Kuralamudhan Ramakrishnan <kuralamudhan.ramakrishnan@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@Miouge1 Miouge1

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkamudhan @k8s-ci-robot @floryut @Miouge1