Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ansible-lint E404 justification #6417

Merged
merged 1 commit into from
Jul 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions roles/container-engine/containerd/tasks/crictl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
vars:
download: "{{ download_defaults | combine(downloads.crictl) }}"

- name: Install crictl config # noqa 404
- name: Install crictl config
template:
src: ../templates/crictl.yaml.j2
src: ../templates/crictl.yaml.j2 # noqa 404 not in role_path when task is included from download role
dest: /etc/crictl.yaml
owner: bin
mode: 0644
Expand Down
4 changes: 2 additions & 2 deletions roles/container-engine/cri-o/tasks/crictl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
vars:
download: "{{ download_defaults | combine(downloads.crictl) }}"

- name: Install crictl config # noqa 404
- name: Install crictl config
template:
src: ../templates/crictl.yaml.j2
src: ../templates/crictl.yaml.j2 # noqa 404 not in role_path when task is included from download role
dest: /etc/crictl.yaml
owner: bin
mode: 0644
Expand Down
8 changes: 4 additions & 4 deletions roles/network_plugin/contiv/tasks/pre-reset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@
- contiv_kubectl.stat.exists
- inventory_hostname == groups['kube-master'][0]

- name: reset | Copy contiv temporary cleanup script # noqa 404
- name: reset | Copy contiv temporary cleanup script
copy:
src: ../files/contiv-cleanup.sh # Not in role_path so we must trick...
src: ../files/contiv-cleanup.sh # noqa 404 Not in role_path so we must trick...
dest: /opt/cni/bin/cleanup
owner: root
group: root
mode: 0750
when:
- contiv_kubectl.stat.exists

- name: reset | Lay down contiv cleanup template # noqa 404
- name: reset | Lay down contiv cleanup template
template:
src: ../templates/contiv-cleanup.yml.j2 # Not in role_path so we must trick...
src: ../templates/contiv-cleanup.yml.j2 # noqa 404 Not in role_path so we must trick...
dest: "{{ kube_config_dir }}/contiv-cleanup.yml" # kube_config_dir is used here as contiv_config_dir is not necessarily set at reset
register: contiv_cleanup_manifest
when:
Expand Down
4 changes: 2 additions & 2 deletions tests/cloud_playbooks/create-aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
instance_tags: "{{ aws.tags }}"
register: ec2

- name: Template the inventory # noqa 404
- name: Template the inventory
template:
src: ../templates/inventory-aws.j2
src: ../templates/inventory-aws.j2 # noqa 404 CI inventory templates are not in role_path
dest: "{{ inventory_path }}"
4 changes: 2 additions & 2 deletions tests/cloud_playbooks/create-do.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
msg: "{{ droplets }}, {{ inventory_path }}"
when: state == 'present'

- name: Template the inventory # noqa 404
- name: Template the inventory
template:
src: ../templates/inventory-do.j2
src: ../templates/inventory-do.j2 # noqa 404 CI templates are not in role_path
dest: "{{ inventory_path }}"
when: state == 'present'
4 changes: 2 additions & 2 deletions tests/cloud_playbooks/create-gce.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
add_host: hostname={{ item.public_ip }} groupname="waitfor_hosts"
with_items: '{{ gce.instance_data }}'

- name: Template the inventory # noqa 404
- name: Template the inventory # noqa 404 CI inventory templates are not in role_path
template:
src: ../templates/inventory-gce.j2
dest: "{{ inventory_path }}"
Expand All @@ -60,7 +60,7 @@
state: directory
when: mode in ['scale', 'separate-scale', 'ha-scale']

- name: Template fake hosts group vars # noqa 404
- name: Template fake hosts group vars # noqa 404 CI templates are not in role_path
template:
src: ../templates/fake_hosts.yml.j2
dest: "{{ inventory_path|dirname }}/group_vars/fake_hosts.yml"
Expand Down