-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow webhook authorization #6502
Conversation
Hi @sulochan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
some YAML to fix to pass CI: ./inventory/sample/group_vars/k8s-cluster/k8s-cluster.yml
73:2 warning missing starting space in comment (comments)
74:2 warning missing starting space in comment (comments)
75:2 warning missing starting space in comment (comments)
78:2 warning missing starting space in comment (comments)
79:2 warning missing starting space in comment (comments)
80:2 warning missing starting space in comment (comments) |
/ok-to-test |
template: | ||
src: webhook-authorization-config.yaml.j2 | ||
dest: "{{ kube_config_dir }}/webhook-authorization-config.yaml" | ||
when: kube_webhook_authorization|default(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This default(false) is redundant because the role defines a default. I understand the task above it is also to blame. Just pointing out a stylistic issue here.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattymo, sulochan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/skip pull-kubespray-yamllint |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows users to use webhook for authorization of api requests.
Which issue(s) this PR fixes:
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: