Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webhook authorization #6502

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

sulochan
Copy link
Contributor

@sulochan sulochan commented Aug 5, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows users to use webhook for authorization of api requests.

Which issue(s) this PR fixes:

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

Users are able to use webhook authorization. Vars to turn this feature is provided
on the sample config.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten August 5, 2020 14:09
@k8s-ci-robot
Copy link
Contributor

Hi @sulochan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2020
@EppO
Copy link
Contributor

EppO commented Aug 5, 2020

some YAML to fix to pass CI:

./inventory/sample/group_vars/k8s-cluster/k8s-cluster.yml
  73:2      warning  missing starting space in comment  (comments)
  74:2      warning  missing starting space in comment  (comments)
  75:2      warning  missing starting space in comment  (comments)
  78:2      warning  missing starting space in comment  (comments)
  79:2      warning  missing starting space in comment  (comments)
  80:2      warning  missing starting space in comment  (comments)

@woopstar
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2020
template:
src: webhook-authorization-config.yaml.j2
dest: "{{ kube_config_dir }}/webhook-authorization-config.yaml"
when: kube_webhook_authorization|default(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default(false) is redundant because the role defines a default. I understand the task above it is also to blame. Just pointing out a stylistic issue here.

@mattymo
Copy link
Contributor

mattymo commented Aug 24, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, sulochan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@mattymo
Copy link
Contributor

mattymo commented Aug 24, 2020

/skip pull-kubespray-yamllint

@k8s-ci-robot k8s-ci-robot merged commit 36924b6 into kubernetes-sigs:master Aug 24, 2020
@floryut floryut mentioned this pull request Aug 24, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants