Improve metallb template for bgp peers

[MrFreezeex]

Signed-off-by: Arthur Outhenin-Chalandre arthur@cri.epita.fr

What type of PR is this?
/kind feature

What this PR does / why we need it:
I would like to use ARP to advertise my primary pool of addresses and BGP for other pools. This PR make this possible by adding metallb peers if the user defines some bgp peers whether or not he has defined metallb_protocol as arp or bgp.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[k8s-ci-robot]

Hi @MrFreezeex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

/ok-to-test
/lgtm

[oomichi]

From this PR message

if the user defines some bgp peers whether or not he has defined metallb_protocol as arp or bgp.

according to https://metallb.universe.tf/configuration/ the available protocols seem layer2 and bgp.
What is the protocol arp in the above message?

[oomichi]

/cc @oomichi

[MrFreezeex]

From this PR message

if the user defines some bgp peers whether or not he has defined metallb_protocol as arp or bgp.

according to https://metallb.universe.tf/configuration/ the available protocols seem layer2 and bgp.
What is the protocol arp in the above message?

Yes sure one should defines layer2 and not arp for the metallb_protocol variable. I probably made this mistake because ARP is the protocol used under the hood by metallb in layer2 mode with ipv4.

[oomichi]

Yes sure one should defines layer2 and not arp for the metallb_protocol variable. I probably made this mistake because ARP is the protocol used under the hood by metallb in layer2 mode with ipv4.

I see, but I cannot find the reason why we need to specify peers for layer2 protocol. https://metallb.universe.tf/ doesn't show such case, and the keyword peer appear on bgp protocol only, not on layer2 protocol.

[MrFreezeex]

I see, but I cannot find the reason why we need to specify peers for layer2 protocol. https://metallb.universe.tf/ doesn't show such case, and the keyword peer appear on bgp protocol only, not on layer2 protocol.

On each address pool you can set bgp or layer2 individually. I would like to have my primary address pool in layer2 and some other address pools in bgp.

With the current template this setup is not possible because I would set metallb_protocol to layer2 while I still need to advertise addresses in bgp for some of my pools.

[Miouge1]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment