Add prompt to upgrade node or delay before upgrade #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
champtar
reviewed
Jan 18, 2021
| seconds: "{{ upgrade_node_pause_seconds }}" | ||
| when: | ||
| - not upgrade_node_confirm | ||
| - upgrade_node_pause_seconds != 0 |
There was a problem hiding this comment.
upgrade_node_confirm is a bit useless
There was a problem hiding this comment.
@champtar Is there some other way to better control rolling updates to allow the workload to recover during the draining process.
There was a problem hiding this comment.
Would be nice to have this included in the next release if possible.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
I want control process of upgrade cluster, and I want to be able to check the work of the updated node, before starting the next update.
Also, sometimes you need to wait a little for all the pods to running, before starting the drain of the next node
Does this PR introduce a user-facing change?: