Download crun using download_file.yml

[necatican]

What type of PR is this?

/kind feature

What this PR does / why we need it:

It is needed to standardize the download process. It also is marked as a TODO item.

Which issue(s) this PR fixes:

Fixes #7345

Special notes for your reviewer:

The versioning format is up for consideration. The versions of other software downloaded with download_file.yml start with 'v' meanwhile crun does not. There are three options here:

• Use the native versioning. crun_version: 0.18
• Use the native versioning for the variable, prepend 'v' in roles/download/defaults/main.yml. This is achievable with a filter. crun_binary_checksum: "{{ crun_checksums[image_arch]['v' + (crun_version|string)] }}"
• Use prepended version. crun_version: v0.18 This is the dirtiest option, download URL requires native versioning.

I have decided to use the native versioning. It is possible to switch between different options with ease.

Does this PR introduce a user-facing change?

"crun_release_url" variable is replaced with "crun_download_url"

- Replaced the download URL of Crun. "crun_release_url" - > "crun_download_url" 

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @necatican!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @necatican. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[champtar]

Not sure I have enough power
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, floryut, necatican

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floryut]

@necatican Thank you for the PR! 😄

[necatican]

/assign EppO

[necatican]

/cc oomichi

[oomichi]

Not sure I have enough power
/ok-to-test

@champtar You have enough power to put /lgtm :-)

[oomichi]

Does this 0 mean Kubespray doesn't support 0.16 and 0.17 for arm64?

[necatican]

Arm build for older versions are unavailable on crun releases.

[champtar]

Not sure I have enough power
/ok-to-test

@champtar You have enough power to put /lgtm :-)

Thanks, I though I needed to be added in some OWNER file, but it's to approve only

[floryut]

Not sure I have enough power
/ok-to-test

@champtar You have enough power to put /lgtm :-)

Thanks, I though I needed to be added in some OWNER file, but it's to approve only

Yup it's this case 😄

Technically, anyone who is a member of the kubernetes GitHub organization can drive-by /lgtm a PR
Drive-by reviews from non-members are encouraged as a way of demonstrating experience and intent to become a member or reviewer.
Drive-by /lgtm's from members may be a sign that our OWNERS files are too small, or that the existing reviewers are too unresponsive
This goes against the idea of specifying reviewers in the first place, to ensure that author is getting actionable feedback from people knowledgeable with the code

[champtar]

/lgtm