Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vault #7400

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Remove vault #7400

merged 2 commits into from
Mar 24, 2021

Conversation

champtar
Copy link
Contributor

@champtar champtar commented Mar 24, 2021 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove contrib/vault, this code is dead since 2018

champtar added 2 commits March 23, 2021 20:28
@champtar
Remove contrib/vault
8ab48de 
This is marked as broken since 2018 / 3dcb914
This still reference apiserver.pem, not used since ddffdb6

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
@champtar
Finish nuking vault from the codebase
ab692de 
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten March 24, 2021 00:34
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 24, 2021
@oomichi
Copy link
Contributor

oomichi commented Mar 24, 2021 •
edited
Loading

Please write the reason why we need to remove this on What this PR does / why we need it:
Also I don't think Does this PR introduce a user-facing change?: is NONE on this PR.

@champtar
Copy link
Contributor Author

Sorry, just cleaning dead code, no real changes since 2018, not sure what to say more :)

floryut
floryut approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
And totally agree, contribs code needs to be carefully looked at as they tends to fall way behind..

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@oomichi
Copy link
Contributor

oomichi commented Mar 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit f0cdf71 into kubernetes-sigs:master Mar 24, 2021
@champtar champtar deleted the rm_vault branch March 24, 2021 17:51
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 6, 2021
@champtar @LuckySB
Remove vault (kubernetes-sigs#7400)
ae475b4 
* Remove contrib/vault

This is marked as broken since 2018 / 3dcb914
This still reference apiserver.pem, not used since ddffdb6

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>

* Finish nuking vault from the codebase

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
@floryut floryut mentioned this pull request May 11, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@champtar @sakuraiyuta
Remove vault (kubernetes-sigs#7400)
4c85d08 
* Remove contrib/vault

This is marked as broken since 2018 / 3dcb914
This still reference apiserver.pem, not used since ddffdb6

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>

* Finish nuking vault from the codebase

Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@champtar @oomichi @k8s-ci-robot @floryut