Add documentation for audit webhook variables #7434
Conversation
|
Hi @necatican. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, necatican The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| * `audit_webhook_server_extra_args`: {} | ||
| * `audit_webhook_mode`: batch | ||
| * `audit_webhook_batch_max_size`: 100 | ||
| * `audit_webhook_batch_max_wait`: 1s |
There was a problem hiding this comment.
This point is out of scope from this PR:
According to https://kubernetes.io/docs/tasks/debug-application-cluster/audit/#batching audit_webhook_batch_max_size and audit_webhook_batch_max_wait are used when the audit_webhook_mode is batch.
So these options should be written to kubeadm-config.v1beta2.yaml if the mode is batch only.
There was a problem hiding this comment.
#7444 is created for the above point.
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
* Add documentation for audit webhook variables * Enclose the value of audit_webhook_server_url in a codeblock * Add default value for audit_webhook_batch_max_wait
* Add documentation for audit webhook variables * Enclose the value of audit_webhook_server_url in a codeblock * Add default value for audit_webhook_batch_max_wait
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Variables for the audit webhooks are not present in the documentation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: