Rename ansible groups to use _ instead of -

[cristicalin]

rename ansible groups to use _ instead of -

k8s-cluster -> k8s_cluster
kube-node -> kube_node
calico-rr -> calico_rr
no-floating -> no_floating

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR renames some ansible groups to be consistent with dynamic ansible inventory plugins like AWX.

Which issue(s) this PR fixes:

Fixes #7536

Special notes for your reviewer:
This PR touches a lot of files, I apologize for the giant size.

Does this PR introduce a user-facing change?:

Ansible groups were updated to be more consistent with dynamic inventory plugins:
k8s-cluster -> k8s_cluster
kube-node -> kube_node
calico-rr -> calico_rr
no-floating -> no_floating

[k8s-ci-robot]

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@cristicalin I've remove the "do not merge yet" and put the PR as draft, it's cleaner ;)

[cristicalin]

I added the missing compatibility layer so this should be ready for CI and review.

[cristicalin]

I'm not sure the failure currently in CI is related to the change, as far as I can see the cluster is up and was able to run workloads.

[oomichi]

/ok-to-test

[cristicalin]

I believe the CI needs some love again since the failing test appears to be an ssh timeout unrelated to the changes in this PR.

[cristicalin]

The CI is upset again for some networking (as far as I can tell) reason.

[champtar]

/lgtm
I say let's go ahead fast so anything that was missed can be addressed before next release, and we ask the users to change their inventory only once

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floryut]

@cristicalin Thank you for that 👍

[rptaylor]

Looks like this has also changed kube-node to kube_node, though it is not mentioned in the 2.16 release notes or the description of this PR.

Actually the description says k8s-node -> k8s_node but those group names do not exist.

[floryut]

Looks like this has also changed kube-node to kube_node, though it is not mentioned in the 2.16 release notes or the description of this PR.

Actually the description says k8s-node -> k8s_node but those group names do not exist.

Oops .. you're totally right, I've edit the PR desc in case anyone drop on this PR.